Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.81k stars 318 forks source link

Consistency in naming #908

Closed Beep6581 closed 9 years ago

Beep6581 commented 9 years ago

Originally reported on Google Code with ID 920

We have a bit of inconsistency regarding the usage of some names.

1- The word "raw" is a normal word - it's a raw image made of raw data - not an acronym,
and as such it should be spelled the same as "tea" or "mushroom". The word appears
as "RAW" in come places in our GUI, e.g. the tab's name should be "Raw" not "RAW" -
these inconsistencies should be fixed.

2- Another problem area that could cause ambiguity, especially for novices, is with
the word "profile". It could apply to RT's color theme files, to the PP3 files, or
to the ICC files. I would suggest always being clear about this in the interface, so
if an option involves postprocessing profiles, write "Postprocessing profile foo" instead
of "Profile foo". If it's about ICC files, write "ICC profile foo", and if it's about
the color theme, write "Color theme foo" and not "color scheme" or "color profile".

3- What does PP3 stand for, Post-Processing Profile v3, or Processing Profile v3?
Preferences > Image Processing uses the word "processing" several times, but elsewhere,
such under the histogram in the image editor tab, we use "postprocessing". Let's choose
one and stick to it. I suggest "Post-processing profile".

4- The last issue for now is with .icc/.icm extensions and references to them in the
interface. From what I read, the original extension for those files as decided by the
ICC was .icc, and then some day Microsoft decided it would use .icm extensions (I don't
know if this was before MS left the ICC or after). I would suggest using the original
.icc extension, although I can't say I have any strong argument against .icm other
than it being a Microsoft invention that strays from the ICC's specification. Whichever
one we choose, I urge everyone to stick to the chosen one. It makes the interface,
handbook and forum tutorials clearer.
e.g. the panel in the image editors's color tab is "ICM" but the color management tab
in preferences contains "Directory of ICC profiles".

I can take care of all these inconsistencies in the language files and code, I'll just
first wait for some reactions to this first.

Reported by entertheyoni on 2011-08-16 22:01:56

Beep6581 commented 9 years ago
Another one: the button left under says 'Send to queue' but the raw arrives in the Batch
tab

Reported by paul.matthijsse4 on 2011-08-17 07:17:53

Beep6581 commented 9 years ago
+1 agree.
Consistency should be followed also in the manual.
1) OK
2) I'd avoid Post-processing, and use simply "processing". To distinguish:
Processing profile, Color profile, Theme.
3) Processing profile
4) ICM -> Color management

Reported by ffsup2@yahoo.it on 2011-08-24 17:25:12

Beep6581 commented 9 years ago
1- Fixed

2a- Fixed "ICC"
I chose to use "Color profile" as this encompasses all ICC/ICM/DCP/etc profile types
and synonyms. Of course if something applies only to say DCP, then "DCP profile" should
be used.

2b- Fixed "Profile" and PP3
Agreed with Joker.
I chose to use "Processing Profile" over "Post-processing Profile" because its shorter
and means the same thing (in fact one could argue that what RT does is processing,
and subsequently Photoshop/Gimp would do the postprocessing).

3- PP3
I suggest we define PP3 as "Processing Profile v3" for the reasons above and stick
to it in the forum and manual. We can use XMP after the switch if we need to keep it
short, as in the GUI.

4- ICC/ICM/DCP replaced with "Color profile" where possible.
405 ICMPANEL_NOICM;No ICM: sRGB Output
What part of color management is skipped here? An input profile is applied, so there's
some color management that is not skipped. A working profile is also applied. Why not
just call it "sRGB output"?

5- 
924 TP_ICM_BLENDCMSMATRIX_TOOLTIP;Enable to recover blown highlights when using LUT
based ICC profiles
Does this not apply to LUT based DCP profiles?

6- Batch/Queue
This has been resolved in the past. There are no more references to "Batch" except
for the legitimate use in the Preferences "Batch Processing" tab.

I've attached both a diff, so that you can see the changes, but as diffs of language
files often fail to apply, I've also attached the full file.

Reported by entertheyoni on 2012-04-29 18:37:03

Beep6581 commented 9 years ago
There is a 'Group "Open With"' option in Preferences, does the "Open with" context menu
appear only in Windows?

Reported by entertheyoni on 2012-04-30 12:13:35

Beep6581 commented 9 years ago
Updated the files.
Seems "&" can't be used directly, it has to be replaced with the html character entity.

Reported by entertheyoni on 2012-04-30 12:48:28

Beep6581 commented 9 years ago
Updated the default language file to latest tip 4.0.8.48 and merged in the corrections.
I've attached it to make it easier to see what changed.

File committed after a month of thorough community testing.

Reported by entertheyoni on 2012-05-31 23:15:43