BeerK0in / generator-gunbot

Setup and manage GUNBOT x3 on Linux.
MIT License
32 stars 20 forks source link

Overwrites changes to ALLPAIRS need for Gunbot Proxy CE #16

Open toasthead opened 7 years ago

toasthead commented 7 years ago

When using Gunbot Proxy CE it overwrites changes needed to ALLPAIRS to prevent Node from erroring on a self signed certificate.

https://github.com/taniman/gunbotproxycommunity

GBP CE needs https://github.com/taniman/gunbotproxycommunity In ALLPAIRS

Example

13|BTC_DGB | ::::: collecting market data... 13|BTC_DGB | PLNX CALLBACK | calling EMA self signed certificate 13|BTC_DGB | 2017/07/04 03:24:12 Error: Error: self signed certificate 13|BTC_DGB | !!! Cycle 5 failed. Will repeat in 60s

BeerK0in commented 7 years ago

We could add an option to ginit and gadd to tell the generator to setup for the proxy and add process.env.NODE_TLS_REJECT_UNAUTHORIZED = "0"; to ALLPAIRS.

toasthead commented 7 years ago

That is a bit specific and people not using the community proxy dont' need it and we might not use the community proxy after this next gun bot release.

This isn't needed with Guy Fawkes proxy.

I am probably going to tinker with an nginx or haproxy myself to have more control.

I noticed it only happens when you run ginit and doesn't seem to happen with gadd.

I have been adding pairs by gadd.

Maybe all that is necessary is updating the README and the forum letting people know to add any customer settings they want to the ALLPAIRS?

OR maybe wrap custom mods to ALLPAIRS in comments and then your app make sure they stay?

Not sure the best strategy.