A few changes - Githubissues

BeerK0in / gunbot-monitor

Monitors your GUNBOTs

MIT License

33 stars 15 forks source link

A few changes #10

Closed jbogatay closed 7 years ago

jbogatay commented 7 years ago

Here are a few changes for your consideration.

slight column changes for space/readability
text-alignment for columns
a new --compact option
a new column that shows the results (+/-) of the last 10 trades
displays bought price in yellow for buy column when you have an open position

BeerK0in commented 7 years ago

Thank you! I'll look into it, but I'm very busy right now. Give me 12h to 24h :) A quick scan through your changes: nice! :+1:

jbogatay commented 7 years ago

I'm now wondering if the "last 10 trades" feature is less than useful. Most of the failed trades I have had are because I sold outside of gunbot, otherwise it holds until target met.

Maybe replace with average profit percent or something else that gives clue as to historical performance.

Also I need to add another space to the footer row to fix the missing right border for that row.

BeerK0in commented 7 years ago

I did some minor changes to your code and created another PR: https://github.com/BeerK0in/gunbot-monitor/pull/11