search

BeerMoneyDev / nest-aws-sdk

A thin wrapping layer around the aws-sdk package for clean NestJS dependency injection.
MIT License
92 stars 13 forks source link

AWS SDK v3 #4

Open pedromdev opened 3 years ago

pedromdev commented 3 years ago

Hi,

This is the best module that integrates AWS SDK and NestJS for me. Recently I found a new version of AWS SDK and it's a monorepo now.

As documented here, the major differences are split services in small repos and .promise() method is removed.

How complex is to migrate from v2 to v3?

pedromdev commented 3 years ago

AWS SDK V3 reference link

0xslipk commented 3 years ago

Hi,

This is the best module that integrates AWS SDK and NestJS for me. Recently I found a new version of AWS SDK and it's a monorepo now.

As documented here, the major differences are split services in small repos and .promise() method is removed.

How complex is to migrate from v2 to v3?

I think it will be very hard to integrate aws sdk v3 here, because the v3 uses commands for Init, get the progress and get a result. The best option will be create a new nest-aws-sdk-v3. What do you think @benMain ?

0xslipk commented 2 years ago

Hi guys @pedromdev @KerryRitter, any news about this? I'm serious thinking in doing a nestjs-aws-sdk-v3 module, but I don't want to build a new whole module if we can add it here.

KerryRitter commented 2 years ago

@jarcodallo What do you have in mind as far as design? I am also tentative to use this project to support v3 given how many users are using the aws-sdk v2.

thomaschaaf commented 2 years ago

@KerryRitter couldn't you just make a new major version?

Distortedlogic commented 2 years ago

bump!

I cant wait to see this module for aws v3!

KerryRitter commented 2 years ago

Echoing comments made on the related PR. Truthfully, I no longer work in the AWS space so it is harder for me to work on these tools as I have no projects in this space :) So, I'll need spin up an environment for me to work and test against and then I can properly test this library. Last thing I want to do is release a new version without doing my honest due diligence.

I will put some focused effort in on this this week/weekend. I think we can pull this in and release it as a nest-aws-sdk@3, and keep the nest-aws-sdk as its own branch and release versioning.

What I need to discover on this PR is

(a) how does the DI work here? the modularity pattern changed quite a bit for v3 and I haven't investigated (b) what does an upgrade path look like (i.e. if someone accidentally installs the latest nest-aws-sdk with the aws-sdk v2

jrista commented 2 years ago

Any progress on updating this for aws sdk v3?

ma1022 commented 2 years ago

👀👀👀

raphaelsoul commented 1 year ago

v3 wanted😘

gjuoun commented 1 year ago

Hey, I wrote a library for aws sdk v3 for nest https://github.com/deligenius/aws-sdk-v3-nest