search

BeerMoneyDev / nest-aws-sdk

A thin wrapping layer around the aws-sdk package for clean NestJS dependency injection.
MIT License
92 stars 13 forks source link

Update AWS SDK to v3 #5

Closed pedromdev closed 2 years ago

pedromdev commented 3 years ago

Solves #4

KerryRitter commented 3 years ago

Amazing - I will take a look early this week. Thank you for the contribution!

KerryRitter commented 3 years ago

This looks good! Going to run a couple more tests this week and we can merge and publish this weekend if that sounds good to you. Thank you so much for the contribution.

pedromdev commented 3 years ago

That's great @KerryRitter ! I'm going deeper into the documentation to see the changes in the options of each service. I noted that each service has its options and I don't know if it's possible change it in runtime (like method call). May I create a new PR with new updates.

KerryRitter commented 3 years ago

That's actually my concern that I want to dig deeper into. In V2, each service had (if not exact, essentially) the same service options. I can't tell if that's the same case with V3, in which case the default service options approach might not work out.

On Wed, Mar 10, 2021 at 8:28 AM Pedro Alves @.***> wrote:

That's great @KerryRitter https://github.com/KerryRitter ! I'm going deeper into the documentation to see the changes in the options of each service. I noted that each service has its options and I don't know if it's possible change it in runtime (like method call). May I create a new PR with new updates.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BeerMoneyDev/nest-aws-sdk/pull/5#issuecomment-795492925, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARU6RNZ5U43WJLYZAGPQELTC56Y7ANCNFSM4YYBUBPQ .

0xslipk commented 2 years ago

Hi guys @pedromdev @KerryRitter, any news about this? I'm serious thinking in doing a nestjs-aws-sdk-v3 module, but I don't want to build a new whole module if we can add it here.

augustolima commented 2 years ago

Hey, @pedromdev @KerryRitter. Any updates? People would really appreciate this update. Is there anything we can do to help?

KerryRitter commented 2 years ago

I will put some focused effort in on this this week/weekend. I think we can pull this in and release it as a nest-aws-sdk@3, and keep the nest-aws-sdk as its own branch and release versioning.

What I need to discover on this PR is

(a) how does the DI work here? the modularity pattern changed quite a bit for v3 and I haven't investigated (b) what does an upgrade path look like (i.e. if someone accidentally installs the latest nest-aws-sdk with the aws-sdk v2

KerryRitter commented 2 years ago

Rejecting for now because we have lots of conflicts (because of our fault, sorry). If someone has time to fix this up and do some proving and documentation for this, I am happy to accept a PR to support v3.

It would be ideal to support either v2 OR v3.

troywweber7 commented 1 year ago

What's the verdict on this? V2 is supposed to be deprecated this year, 2023.