Beethoven92 / BetterEndForge

Other
25 stars 28 forks source link

Concerns with IForgeSheerable and Mods' Sheer Compatibility #174

Open oitsjustjose opened 3 years ago

oitsjustjose commented 3 years ago

Overview

Heya! I was debugging a bit of odd behavior on my server lately and noticed that the Mosses (as well as leaves) do not utilize the tooltype Shears, nor do they attempt to utilize any form of tag (such as #forge:shears built right into Forge). As a result, other mods (such as Tinkers' Kama as well as Botania's two magic-based varieties of Shears do not work.

In addition, I noticed something that caught my eye -- all of the blocks that are meant to require shears (which has already been done via Datapack Loot Table) seem to implement IForgeSheerable. This Interface is meant for items that need to emulate the functionality of shears across the board, since this part of MC isn't exactly data-driven.

Versions

I can provide this info if you'd like, but I'm sourcing my concerns from the code currently in the repo, so I can't exactly say where the problem lies (as far as a version number).

If you accept PRs, I'd be glad to make this change 😄