BeetoGuy / LevelUp2

Rewrite of the original, with a skill tree
18 stars 14 forks source link

Crash Between LevelUp2, DynamicSurroundings, and Various Other Mods #74

Closed VT-14 closed 4 years ago

VT-14 commented 4 years ago

(using issue template supplied by Dynamics Surroundings)

Mod Version:

DynamicSurroundings-1.12.2-3.6.1.0 levelup2-1.3.0-shaded OreLib-1.12.2-3.6.0.1

Forge Version:

forge-1.12.2-14.23.5.2854

Link to client log:

Botania Trigger: https://gist.github.com/VT-14/3bfcc8e38f3d18bd8ae715704e5dfbdf The Betweenlands Trigger: https://gist.github.com/VT-14/4d3a70dbdb8002879ca5e65e0c983e9b

Link to crash log:

Botania Trigger: https://gist.github.com/VT-14/fcd4292a00e9b5ec0395c2f05cdffe74 The Betweenlands Trigger: https://gist.github.com/VT-14/efbda0f287aa909a4e4ff989b817c588

Description:

Using both Level Up 2 and Dynamic Surroundings, along with any number of 'trigger' mods, will cause the game to crash. The first line in the stacktrace is always:

java.lang.NoSuchMethodError: net.minecraftforge.common.capabilities.Capability$IStorage.writeNBT(Lnet/minecraftforge/common/capabilities/Capability;Ljava/lang/Object;Lnet/minecraft/util/EnumFacing;)Lnet/minecraft/nbt/NBTBase;

From there, the stacktrace points out code in the 'trigger' mod. Attempting to remove that 'trigger' mod usually results in a new mod triggering the crash and getting blamed instead.

The two known 'trigger' mods I've used are Botania and The Betweenlands. Since this appears to be NBT related, I expect there are far more out there. This post on /r/FeedTheBeastCrashes (where I first saw this issue) suggests that Everlasting Abilities and Locks are also affected, and a conversation in the Ender IO Discord's bug report channel brought up this crash report implying an issue between Craft Tweaker, Nuclearcraft, and Ender IO.

The author of that Reddit post managed to solve their crash by removing Level Up 2. I passed that on to the Discord User and they managed to solve the issue the same way. I investigated further on my own and managed to narrow the mod list down to these 2 mods, a trigger mod, and dependencies. To recap:

The tested "Trigger" mods were Botania and The Betweenlands. Others are believed to exist.


Furthermore, I found that when Level Up 2 is combined with either Phosphor or VanillaFix, the modpack won't even launch. Adding Dynamic Surroundings does allow the pack to launch without any immediately apparent issues (other than the rest of this bug report).

Link to Issue on Dynamic Surroundings GitHub

OreCruncher/DynamicSurroundings/issues/560

OreCruncher commented 4 years ago

If I am reading the Level Up build.gradle correctly it is using the 0.7.11 version of Mixin. The conflicted mods have moved to 0.8.

BeetoGuy commented 4 years ago

Yeah, looks like I'll have to bump that up.