search

Befaco / MIDIThing2

MIDI Thing 2 Code
10 stars 0 forks source link

Hanging gate with MPC Live when playing chord with more notes than configured voices #40

Open jjobse opened 3 weeks ago

jjobse commented 3 weeks ago

Using an MPC live in pad perform mode if I send a chord to a single voice then the gate hangs indefinitely. The only way to get it to stop is to switch to a single note and play that by itself.

This seems to happen whenever you send a chord with more notes than are configured on the midi thing. For example if I play a 5note chord with 4voices configured it will cause the hang behavior.

I found I was able to replicate this 100% of the time on the MPC Live on a midi track within the Pad Perform screen.

xustafu commented 2 weeks ago

Gate behavior works that it only comes down (or trigers Release stage in ADSR) when a Note OFF arrives. So if chord is infinite and/or no note OFF are sent, gate will not come down. Get a MIDI monitor on your computer and check how Note OFF are sent when overlaping notes happen or you send long ones.

jjobse commented 2 weeks ago

Hey there, no problem. I have attached my logs, a screenshot, and a video.

For this test I configured the midi thing v2 to have 1 voice and 1 gate attached to that voice. From the MPC I sent a 3-note chord which resulted in a hung gate.

I can see all of the midi messages are being sent as expected. However the midithingv2 is not responding accordingly. Maybe it has to do with the timing of the note off messages being too close to each other (.001 secs apart)?

Please let me know if there is anything else I can do to assist.

mpc_chord_midi.csv

midi_thing_v2_midi_snap

https://github.com/user-attachments/assets/fb7ac1e7-a61c-40c4-867f-bb428e83579e

xustafu commented 2 weeks ago

And this example, sending those three notes from the log, does hang the gate?

Cannot reproduce the issue with a MIDI keyboard!

@SergioRetamero can you reproduce this issue?

jjobse commented 2 weeks ago

Yes that produces the hung gate.

When using just a midi keyboard on my moog it works fine. I have no idea why it fails in the scenario.

Can you test using a DAW or something that sends the note on/off commands at the exact same time? (Technically .001 seconds apart) That’s the only difference I can think of.

xustafu commented 2 weeks ago

Replicated in bitwig. With two notes sent at the same time with the same lenghth it is fine, from the third note gate hangs. Reporting as a bug!

SergioRetamero commented 1 week ago

MidiThing2.zip Looks like when the timestamp is exactly the same, a retrigger might happen and leave the note hanging. Please test this firmware and check if it solves the issue. Thanks

jjobse commented 1 week ago

Sorry for the delayed response. I was able to test and verified that this bug is fixed! No issues on my end. Thanks for all the help!

jjobse commented 1 week ago

After some more testing it looks when playing chords with not enough voices configured the note out jumps around for an unstable sounds.

jjobse commented 3 days ago

To expand on this a little more it appears when the chord is struck the midi thing is taking some time (fast like a millisecond) to pick which note to play. This is the little blip I am hearing. You can see the note jumping around on the midi thing GUI as well. Maybe this is due to note priority? I will check again to see if note priority has any impact on this behavior.