Befaco / Oneiroi

A live performance-oriented, multi-functional, self-contained experimental digital synth for the OWL platform
https://www.befaco.org/oneiroi
GNU General Public License v3.0
15 stars 0 forks source link

Beta 6 for v1.1 #22

Closed hirnlego closed 1 week ago

hirnlego commented 1 week ago

Here:

https://github.com/Befaco/Oneiroi/releases/tag/v1.1-beta.6

Both echo's clicking when sync'd and looper's clicking when looping should be fixed. I also improved the fade when the looper is retriggered, to avoid nasty clicks.

rootapprox commented 1 week ago

Great ! trying it now! Works great now !

rootapprox commented 1 week ago

I noticed some weird pitch shifting(like DJ spinnin) occurs with the SYNC IN used only,( tried without synced clock and it works fine ) here an example of a little loop with just Input UP and Echo Fully wet. you will hear some little transitions of pitch from time to another in the loop 8-Audio 0001 [2024-11-11 172426].wav.zip

hirnlego commented 1 week ago

@rootapprox were you changing DENSITY? Changing DENSITY causes a pitch shift, regardless of the way it is changed (knob, CV, modulation), and when the echo is sync'd the effect is that a short pitch shift happens when stepping from a time division to the other. The solution to this would be removing pitch shifting from DENSITY when echo is sync'd, I thought about it but I like this effect.

hirnlego commented 1 week ago

@Diegoterrores I've added a few details in the release's notes that should also be added to the manual, specifically the fact that the version number in the web page doesn't change (it shows the firmware's version, not the patch's). We should think of a way to display the patch's version, maybe using the LEDs on startup.

WiretapStudios commented 1 week ago

The looper is working great! Probably the best I've heard it so far, I tried several dozen and made some really nice stuff. Adjusting the start and end does introduce clicks at many spots, but if that's the nature of the beast then I'm OK with at least the full loop being clean.

rootapprox commented 1 week ago

@rootapprox were you changing DENSITY? Changing DENSITY causes a pitch shift, regardless of the way it is changed (knob, CV, modulation), and when the echo is sync'd the effect is that a short pitch shift happens when stepping from a time division to the other. The solution to this would be removing pitch shifting from DENSITY when echo is sync'd, I thought about it but I like this effect.

Nope i was not changin the DEENSITY ( nor knob, CV or Mod) , it is fixed when this happens ...

hirnlego commented 1 week ago

The looper is working great! Probably the best I've heard it so far, I tried several dozen and made some really nice stuff. Adjusting the start and end does introduce clicks at many spots, but if that's the nature of the beast then I'm OK with at least the full loop being clean.

By "clicks" you mean actual waveform discontinuities? And do those clicks continue when you stop modifying START and/or LENGTH? Is the change of the parameters the cause or is it the loop point?

hirnlego commented 1 week ago

@rootapprox were you changing DENSITY? Changing DENSITY causes a pitch shift, regardless of the way it is changed (knob, CV, modulation), and when the echo is sync'd the effect is that a short pitch shift happens when stepping from a time division to the other. The solution to this would be removing pitch shifting from DENSITY when echo is sync'd, I thought about it but I like this effect.

Nope i was not changin the DEENSITY ( nor knob, CV or Mod) , it is fixed when this happens ...

I can't reproduce it on my unit if DENSITY is not touched in any way. @WiretapStudios are you experiencing this issue as well?

rootapprox commented 1 week ago

@rootapprox were you changing DENSITY? Changing DENSITY causes a pitch shift, regardless of the way it is changed (knob, CV, modulation), and when the echo is sync'd the effect is that a short pitch shift happens when stepping from a time division to the other. The solution to this would be removing pitch shifting from DENSITY when echo is sync'd, I thought about it but I like this effect.

Nope i was not changin the DEENSITY ( nor knob, CV or Mod) , it is fixed when this happens ...

I can't reproduce it on my unit if DENSITY is not touched in any way. @WiretapStudios are you experiencing this issue as well?

Are you sure you are having a clock sent to the SYNC IN ? it happens when only there is a clock in the SYNC IN , i sent you a wav file explaining that sound ( it sounds like a laser gun fx ) i dont get why when you send constant clock u have the delay like everytime catch up in the same place thus that laser sound

hirnlego commented 1 week ago

@rootapprox yes, I'm syncing the module.

After checking the videos you sent me it's evident that there's an issue there, the problem is replicating it on my side. In your case it sounds like as if you didn't update to beta 6 o you were modulating DENSITY somehow, but as you confirmed to me that you updated correctly and cleared every modulation, I'm a bit lost. Let's see if any other beta tester has the same issue, in meantime I try to investigate a bit more.

rootapprox commented 1 week ago

@hirnlego Yes i confirm that i updated to the latest plus did the calibration just in case , removed all the files from the resources just the cfg one ... i suspect this happened when you tweaked the Sync IN click of the density , for now im using it without SYNC IN clock to avoid the laser repitch. for now after investigating more with the clock and the positions of the density , the videos i sent you they were using very slow clock 1 each 64 steps , with density fully counter clockwise i dont hear that laser repitch after 10 o clock it starts to appear, also when i changed the clock to just 1 each 16 steps (PPQN/96) the laser sounds disappeared.. so i guess maybe this happened cause of the long clock im sending , im more confused now ..

hirnlego commented 1 week ago

@rootapprox what you're experiencing is just the click of the previous beta but with the pitch shift effect. The click is (was) the delay time that jumps around due to instability in the clock reading, thing that should have been mitigated by applying averaging and some logic to the operation. It's possible that in case of slow clocks this fix is not enough, I have to check again. Thanks for the report!

rootapprox commented 1 week ago

Yes as i read in the manual It is advisable to use a clock with a trigger per bar or less, such as a trigger every four bars or so, as the same clock is used for these three different tasks, including resetting the looper. so i programmed my beatstep pro to send a slow clock ( trigger each 4 bars ) and the for now if i want to get rid of that laser sound of the delay i have to choose fast clocks , like one each bar , and its gone the problem, hope everything i described helps in a way ! Great work !

cdromain commented 1 week ago

@Diegoterrores I've added a few details in the release's notes that should also be added to the manual, specifically the fact that the version number in the web page doesn't change (it shows the firmware's version, not the patch's). We should think of a way to display the patch's version, maybe using the LEDs on startup.

Thanks, much appreciated Roberto !

hirnlego commented 1 week ago

Yes as i read in the manual It is advisable to use a clock with a trigger per bar or less, such as a trigger every four bars or so, as the same clock is used for these three different tasks, including resetting the looper. so i programmed my beatstep pro to send a slow clock ( trigger each 4 bars ) and the for now if i want to get rid of that laser sound of the delay i have to choose fast clocks , like one each bar , and its gone the problem, hope everything i described helps in a way ! Great work !

As long as the clock received by Oneiroi is >= 30 BPM you should be fine and don't experience any zapping effect. I tried with a 30 BPM clock and had no problem, with a slower clock things begin to fall apart, including the zapping effect. You're most probably using a clock too slow.

Anyway, I'm still on the fence about keeping the pitch shifting when externally sync'd, I'll see.

cdromain commented 1 week ago

Hey guys, reporting after installing and testing beta 6 tonight.

The great news : the looper clicks situation is much much better and it's now an almost click free experience, great job @hirnlego 🙌🏼

Unfortunately I still got some clicks during my tests (albeit a lot less than with previous betas).

I am not referring to artifacts when changing parameters, but repeated "looping clicks", I imagine around the loop point.

More details :

Hope it's helpful and we can make them go away for good ! Love Oneiroi and its looper so much, so playable I can't stop 🔥

hirnlego commented 1 week ago

@cdromain if I understand correctly you are recording POST with also the looper present in the mix, so what you're actually recording is like having sound on sound on but with also the two oscillators, right? If this is the case, I think that there is too much going on there to expect a recording without any type of audio discontinuity. Do you have the same issues when recording PRE?

cdromain commented 1 week ago

@cdromain if I understand correctly you are recording POST with also the looper present in the mix, so what you're actually recording is like having sound on sound on but with also the two oscillators, right? If this is the case, I think that there is too much going on there to expect a recording without any type of audio discontinuity. Do you have the same issues when recording PRE?

Hey, no I was recording POST only with oscillators into FX (looper not in the mix). Recording a few seconds (> 5) then removing the oscillators and FX from the mix and focusing on the looper only. Will test with PRE tonight and report back 👍🏼

hirnlego commented 1 week ago

@rootapprox @cdromain please check the latest beta 7 and report on your issues here https://github.com/Befaco/Oneiroi/issues/24, thanks!

I've made a couple of changes and hopefully at least the zapping effect should have been eliminated, this time I had to remove the pitch shifting effect when the module is sync'd, but it's better for this scenario.

I've also smoothed some more the looper's controls.

Closing this one!

cdromain commented 1 week ago

I'm on it man 🔥

rootapprox commented 1 week ago

@rootapprox @cdromain please check the latest beta 7 and report on your issues here #24, thanks!

I've made a couple of changes and hopefully at least the zapping effect should have been eliminated, this time I had to remove the pitch shifting effect when the module is sync'd, but it's better for this scenario.

I've also smoothed some more the looper's controls.

Closing this one!

Perfect !! i guess thats why in some nice delays around the pitch shifting its not there when its Synced with a clock, great job ! cause the trigger of that clock its also controlling the looper trigger, its the best call to do that ( since that was my reason to use very slow clock , to not have the looper plays in a row .)