search

BeforeIDieCode / BeforeIDieAchievements

🌟An open source project that helps developers make their first pull request and contribute to open source projects. 🚀🎯 Developers can contribute by sharing what they want to do before they die. 💡🔗
https://before-i-die-achievements.vercel.app
MIT License
117 stars 184 forks source link

Updated guidelines for nomore than 7 col in a row #102

Closed Nawarajkarki closed 1 year ago

Nawarajkarki commented 1 year ago

Issue Addressed

Closes #25

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
before-i-die-achievements ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 9:58pm
XanderRubio commented 1 year ago

Hi @Nawarajkarki

Could you please provide more details about your pull request? I'm not entirely sure about the enhancements you're adding to the project. Please go ahead with first adding by sharing your before I die statement and then opening up a new pull request. Thank you!

Nawarajkarki commented 1 year ago

Hi @XanderRubio

Thank you for your response. The changes in my pull request are made addressing one of the open issues, (Issue number #25 ) OR just click here to view the issue

I have modified the CONTRIBUTION-GUIDELINES explaining the Contributors to add maximum of 7 contributors per row.

According to the Open Issue the explanation was to be added to Step 8 of the CONTRIBUTION-GUIDELINES

Go through these pages for a quick comparison

Updated version

Current version

XanderRubio commented 1 year ago

Hi @XanderRubio

Thank you for your response. The changes in my pull request are made addressing one of the open issues, (Issue number #25 ) OR just click here to view the issue

I have modified the CONTRIBUTION-GUIDELINES explaining the Contributors to add maximum of 7 contributors per row.

According to the Open Issue the explanation was to be added to Step 8 of the CONTRIBUTION-GUIDELINES

Go through these pages for a quick comparison

Updated version

Current version

Thank you for the clarification, @Nawarajkarki. I understand now. Does it seem clear to you how step 8 is set up to explain what to do if there are seven columns and a new contributor needs to start a new one? I ask because I would like to get feedback from another contributor to ensure that it is understandable. Thank you for your time. I agree with the changes you have made so far and want to confirm that step 8 is clear and organized in its steps upon first reading. Thank you for your help and for taking ownership of this issue. Well done! I await your feedback.

XanderRubio commented 1 year ago

Thank you @Nawarajkarki, for your time in assisting and contributing, and this closes out issue #25. Please go ahead and share what you want to do before you die! Have a nice day!