BeforeIDieCode / BeforeIDieAchievements

🌟An open source project that helps developers make their first pull request and contribute to open source projects. πŸš€πŸŽ― Developers can contribute by sharing what they want to do before they die. πŸ’‘πŸ”—
https://before-i-die-achievements.vercel.app
MIT License
114 stars 178 forks source link

Update new languages in i18nextConfig.js #132

Closed Mominarez closed 12 months ago

Mominarez commented 12 months ago

fixed syntax error

Issue Addressed

Proposed Changes and Benefits

Screenshots

Notes to Reviewers

Checklist

vercel[bot] commented 12 months ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
before-i-die-achievements ❌ Failed (Inspect) Sep 23, 2023 9:55am
XanderRubio commented 12 months ago

Hi @Mominarez,

I appreciate your time and enthusiasm in working on the translations! πŸ˜‡ I'd like to suggest a more efficient approach for both of us when contributing your changes. Instead of creating multiple pull requests for each translation or file modification, it's better to make all your changes on a single branch and then create just one pull request.

To do this, you can work on the same branch for all your translation updates and file edits. Once you've completed your work and are ready to submit it for review, go ahead and open a single pull request. This will make it easier for me to review all your changes in one place, streamlining the review process.

Thank you again for your contributions, and please feel free to reach out if you have any questions or need further clarification.

Mominarez commented 12 months ago

Hi @Mominarez,

I appreciate your time and enthusiasm in working on the translations! πŸ˜‡ I'd like to suggest a more efficient approach for both of us when contributing your changes. Instead of creating multiple pull requests for each translation or file modification, it's better to make all your changes on a single branch and then create just one pull request.

To do this, you can work on the same branch for all your translation updates and file edits. Once you've completed your work and are ready to submit it for review, go ahead and open a single pull request. This will make it easier for me to review all your changes in one place, streamlining the review process.

Thank you again for your contributions, and please feel free to reach out if you have any questions or need further clarification.

Hello @XanderRubio,

Thank you for letting me know about a more efficient approach in pull requests and I apologize for making it difficult to review them on your end. I will open a single pull request by today.

XanderRubio commented 12 months ago

Hi @Mominarez, I appreciate your time and enthusiasm in working on the translations! πŸ˜‡ I'd like to suggest a more efficient approach for both of us when contributing your changes. Instead of creating multiple pull requests for each translation or file modification, it's better to make all your changes on a single branch and then create just one pull request. To do this, you can work on the same branch for all your translation updates and file edits. Once you've completed your work and are ready to submit it for review, go ahead and open a single pull request. This will make it easier for me to review all your changes in one place, streamlining the review process. Thank you again for your contributions, and please feel free to reach out if you have any questions or need further clarification.

Hello @XanderRubio,

Thank you for letting me know about a more efficient approach in pull requests and I apologize for making it difficult to review them on your end. I will open a single pull request by today.

@Mominarez No need to apologize as open source, git, the world of software is a lifelong learning pursuit and we are all constantly learning new topics and workflow every day.

Mominarez commented 11 months ago

Hi @Mominarez, I appreciate your time and enthusiasm in working on the translations! πŸ˜‡ I'd like to suggest a more efficient approach for both of us when contributing your changes. Instead of creating multiple pull requests for each translation or file modification, it's better to make all your changes on a single branch and then create just one pull request. To do this, you can work on the same branch for all your translation updates and file edits. Once you've completed your work and are ready to submit it for review, go ahead and open a single pull request. This will make it easier for me to review all your changes in one place, streamlining the review process. Thank you again for your contributions, and please feel free to reach out if you have any questions or need further clarification.

Hello @XanderRubio, Thank you for letting me know about a more efficient approach in pull requests and I apologize for making it difficult to review them on your end. I will open a single pull request by today.

@Mominarez No need to apologize as open source, git, the world of software is a lifelong learning pursuit and we are all constantly learning new topics and workflow every day.

Hello! I've been caught up with work so it looks like I wont be able to complete it this weekend as I thought I would, is it okay if I can finish this assignment on Wednesday? If not, I understand if you assign this task to someone else. Thank you!

XanderRubio commented 11 months ago

Hi @Mominarez, I appreciate your time and enthusiasm in working on the translations! πŸ˜‡ I'd like to suggest a more efficient approach for both of us when contributing your changes. Instead of creating multiple pull requests for each translation or file modification, it's better to make all your changes on a single branch and then create just one pull request. To do this, you can work on the same branch for all your translation updates and file edits. Once you've completed your work and are ready to submit it for review, go ahead and open a single pull request. This will make it easier for me to review all your changes in one place, streamlining the review process. Thank you again for your contributions, and please feel free to reach out if you have any questions or need further clarification.

Hello @XanderRubio, Thank you for letting me know about a more efficient approach in pull requests and I apologize for making it difficult to review them on your end. I will open a single pull request by today.

@Mominarez No need to apologize as open source, git, the world of software is a lifelong learning pursuit and we are all constantly learning new topics and workflow every day.

Hello! I've been caught up with work so it looks like I wont be able to complete it this weekend as I thought I would, is it okay if I can finish this assignment on Wednesday? If not, I understand if you assign this task to someone else. Thank you!

Hi @Mominarez, I've updated task #76 to be due by the end of the day on Wednesday. Another contributor has expressed interest in working on the remaining parts of the issue, but since you've already invested time and effort into it, I don't want you to feel like your work has gone to waste. I hope you have a great start to your week!

XanderRubio commented 11 months ago

Hi @Mominarez,

I have informed the other contributor who was inquiring about the remaining language translations that they can start working on it now. Of course, you are always welcome to continue contributing to Before I Die Code whenever you want. Our goal is to make it a great place for developers to improve their skills. Have a wonderful rest of your week!