BeforeIDieCode / BeforeIDieAchievements

🌟An open source project that helps developers make their first pull request and contribute to open source projects. πŸš€πŸŽ― Developers can contribute by sharing what they want to do before they die. πŸ’‘πŸ”—
https://before-i-die-achievements.vercel.app
MIT License
117 stars 184 forks source link

location and geocoding update #134

Closed sherikovic closed 1 year ago

sherikovic commented 1 year ago

Update on #97

Issue Addressed

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
before-i-die-achievements βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 26, 2023 10:28pm
XanderRubio commented 1 year ago

@sherikovic excellent job on the recent updates! I noticed that you've made it possible for users to exit the user card by simply clicking outside of the box. Additionally, the image lighting issue has been resolved by removing the blue border that made it appear clickable. The elimination of the satellite and map buttons has resulted in a more aesthetically pleasing Google Maps display with increased real estate. I'm very impressed that you were able to effectively fetch data from the JSON file, convert it to longitude and latitude, and accurately plot it on the Google Maps API. We'll create a separate issue for the flyover effect, as this is a future UI enhancement.

Our goal is to always offer new UI/UX enhancements for developers to enhance their skills and showcase them as proof. Great work! I'll proceed with merging it into the main and double-check that the API key is correctly fetching on the main.

XanderRubio commented 1 year ago

This feature now closes the issue #97