search

BeforeIDieCode / BeforeIDieAchievements

🌟An open source project that helps developers make their first pull request and contribute to open source projects. 🚀🎯 Developers can contribute by sharing what they want to do before they die. 💡🔗
https://before-i-die-achievements.vercel.app
MIT License
116 stars 183 forks source link

Feature Created Contributors Page. #139

Closed MarcianoN closed 1 year ago

MarcianoN commented 1 year ago

Issue Addressed

Closes #135 Added a contributors page, ContributorsGrid component, and a style sheet for that component. Also added routing to the page.

Proposed Changes and Benefits

I have created a contributors page for the website. Each contributor will be shown as a clickable card that leads to their GitHub profile.

Screenshots

FeatureScreenShot

Notes to Reviewers

I did use npm install react-router-dom to create the routing.

Checklist

vercel[bot] commented 1 year ago

@MarcianoN is attempting to deploy a commit to the Before I Die Code Team on Vercel.

A member of the Team first needs to authorize it.

XanderRubio commented 1 year ago

Issue Addressed

Closes #135 Added a contributors page, ContributorsGrid component, and a style sheet for that component. Also added routing to the page.

Proposed Changes and Benefits

I have created a contributors page for the website. Each contributor will be shown as a clickable card that leads to their GitHub profile.

Screenshots

FeatureScreenShot

Notes to Reviewers

I did use npm install react-router-dom to create the routing.

Checklist

  • [x] I have thoroughly read and understand The Contribution Guidelines.

  • [x] The title of this PR follows the keyword: brief description of change format, using one of the following keywords:

    • Feature - adds new or amends existing user-facing behavior.
    • Chore - changes that have no user-facing value, refactors, dependency bumps, etc.
    • Fix - bug fixes.
    • Docs - fixing typos and adding new content.
  • [x] I have listed my proposed changes and their benefits.
  • [x] I have linked the corresponding issue in the Issues section.

Wow, I haven't looked at the preview deployment link, and I love how the screenshot turned out of your design. Very professional looking! Clapping Hands

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
before-i-die-achievements ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 2:18pm
MarcianoN commented 1 year ago

Thanks for the kind words, @XanderRubio ! I had alot of fun with making this page and I learned a lot! I hope I'll be able to do more contributions like this in the future or even more difficult ones when I get better at coding!

XanderRubio commented 1 year ago

Thanks for the kind words, @XanderRubio ! I had alot of fun with making this page and I learned a lot! I hope I'll be able to do more contributions like this in the future or even more difficult ones when I get better at coding!

You are welcome to contribute to this project by suggesting features and improvements that interest you 😇. Additionally, I had to switch to merging your work into the BeforeIDieCode:feature-contributor-page to fix a conflict and will now merge it into the main branch. The process can become complicated quickly, and it is best to merge your feature work into the feature branch of the main if it exists (though it may not always be the case).

XanderRubio commented 1 year ago

This pull request is for issue #135 and will be closed one the feature is merged into the main branch