BeforeIDieCode / BeforeIDieAchievements

🌟An open source project that helps developers make their first pull request and contribute to open source projects. πŸš€πŸŽ― Developers can contribute by sharing what they want to do before they die. πŸ’‘πŸ”—
https://before-i-die-achievements.vercel.app
MIT License
115 stars 178 forks source link

Refactor: ♻️ refactored html structure in contributors md #192

Closed DiguyaDeveloper closed 11 months ago

DiguyaDeveloper commented 11 months ago

Refactored html structure in contributors md because is broked, the tab was broked and was missing a tr tag! Add my profile DiguyaDeveloper in contributors!

Issue Addressed

Don't have open issue to this

Proposed Changes and Benefits

The actual file of contributors has difficult increment, porque o code indentation had broken

Screenshots

image

Notes to Reviewers

I think we could remove the table concept and just be a list, as the content would be adaptable to the screen size, with the table concept we limit the columns and then we have a maximum width, can we open an issue for this?

Checklist

vercel[bot] commented 11 months ago

@DiguyaDeveloper is attempting to deploy a commit to the Before I Die Code Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
before-i-die-achievements βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 12, 2023 7:03pm
XanderRubio commented 11 months ago

Thank you, @DiguyaDeveloper, for your contribution to the contributor.md file. I apologize for any previous oversight in omitting your name from the CONTRIBUTORS.md file when merging pull requests. Your assistance and contribution are greatly appreciated!

XanderRubio commented 11 months ago

Thank you, @DiguyaDeveloper, for your contribution to the contributor.md file. I apologize for any previous oversight in omitting your name from the CONTRIBUTORS.md file when merging pull requests. Your assistance and contribution are greatly appreciated!

Ahh, I now see after reviewing another pull request that you haven't added your text or image before and that is why you hadn't had your name on the CONTRIBUTORS.md file before.