[BUG] heartBeat and typing sound effects does not work correctly

BeforeIDieCode / BeforeIDieAchievements

🌟An open source project that helps developers make their first pull request and contribute to open source projects. 🚀🎯 Developers can contribute by sharing what they want to do before they die. 💡🔗

https://before-i-die-achievements.vercel.app

MIT License

115 stars 178 forks source link

[BUG] heartBeat and typing sound effects does not work correctly #207

Closed negar-75 closed 10 months ago

negar-75 commented 10 months ago

Description

in the footer component, the heartBeat and typing sound effects should work properly onMouseEnter and onMouseLeave but they don't.

Screenshots

No response

Any additional information?

No response

What browser are you seeing the problem on?

No response

Checklist

[X] I have checked for duplicate issues
[X] I have read the Contribution Guidelines
[X] I am willing to work on this issue (optional)

XanderRubio commented 10 months ago

Exellent @negar-75! Reviewing your PR now!

XanderRubio commented 10 months ago

@negar-75 are you interested in working on another UI issue for the site?

I want to improve the UI for this section, which is the RandomContributor component.

negar-75 commented 10 months ago

I will go for it but before it I want to implement lazy loading for component for aiming better performance and reduce the rendering time ! what do you think about it?

XanderRubio commented 10 months ago

I will go for it but before it I want to implement lazy loading for component for aiming better performance and reduce the rendering time ! what do you think about it?

Yes and even better! Am I correct in remembering that you wrote about this several days ago on an issue you brought up before? Regardless it is a great idea to speed up the loading time, and this would be a massive enhancement on the UX. Great idea! Once you create the issue I will go ahead with assigning the issue to you👍🏻