BeforeIDieCode / BeforeIDieAchievements

🌟An open source project that helps developers make their first pull request and contribute to open source projects. πŸš€πŸŽ― Developers can contribute by sharing what they want to do before they die. πŸ’‘πŸ”—
https://before-i-die-achievements.vercel.app
MIT License
116 stars 183 forks source link

fixed playing issue on hover #208

Closed negar-75 closed 1 year ago

negar-75 commented 1 year ago

Issue #207

Closes #207

Proposed Changes and Benefits

hovering and unhovering on footer emojis did not work well in chrome when emoji was hovered the audio started to play but by unhoveing it still played and if you hovered again you could listen the audio double at the same time. in firefox , you have to click on the emojis to audio started to play and it wouldn't stop I fixed them buy Audio built-in class and added some functions

Checklist

vercel[bot] commented 1 year ago

@negar-75 is attempting to deploy a commit to the Before I Die Code Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
before-i-die-achievements βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 16, 2023 5:52pm
XanderRubio commented 1 year ago

Congratulations @negar-75, for your bug fix and PR being merged! This closes issue #207 βœ…

negar-75 commented 1 year ago

thanks @XanderRubio I am really glad to hear your thoughts and opinion about what I did