BeforeIDieCode / BeforeIDieAchievements

🌟An open source project that helps developers make their first pull request and contribute to open source projects. πŸš€πŸŽ― Developers can contribute by sharing what they want to do before they die. πŸ’‘πŸ”—
https://before-i-die-achievements.vercel.app
MIT License
114 stars 178 forks source link

Feature 48 #64

Closed XanderRubio closed 1 year ago

XanderRubio commented 1 year ago

@negar-75 added code from pull request #52 to enhance the UI

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
before-i-die-achievements βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 6, 2023 9:51pm
XanderRubio commented 1 year ago

This pull request successfully closes issue #48, and thank you to contributor @negar-75 for her pull request #52 and adding UI enhancement.

negar-75 commented 1 year ago

so now everything has been solved?

negar-75 commented 1 year ago

this is my first time working with Git and Git flow and that was hard experience πŸ˜‚πŸ˜‚πŸ˜‚πŸ˜‚πŸ˜‚

XanderRubio commented 1 year ago

so now everything has been solved?

Yes, it has! Please look at the live link for the website for proof.

negar-75 commented 1 year ago

although I have no idea about what just happened , but that was practical experience πŸ˜‚πŸ˜‚πŸ˜‚

negar-75 commented 1 year ago

I see!! amazing😍😍😍😍

negar-75 commented 1 year ago

I am so ready to make another change !!!😍😍😍😍 and learn more and more about Git flow

XanderRubio commented 1 year ago

I see!! amazing😍😍😍😍

Congratulations on gaining more experience with Git today than you might have thought possible when starting out. I will do my best to provide a brief description of what happened. The main issue we encountered was that your forked version and add features branch of issue-#48 hadn't been fetched to be udaped with the main working branch of the Before I Die Code repo. This was a valuable lesson for me, and we will need to have proper documentation in place to make it easier for other developers to understand and receive support on how to prevent merge conflicts from happening. If conflicts do occur, the only option is to merge the main branch into the feature branch, potentially losing the work that you want to add to the main branch and needing to revert the commit. I need to understand why this is occurring. Please let me know if you have any further questions. I will be signing off for tonight, but I would like to hear your thoughts on how we can continue to improve the UI to look more professional and sleek. Have a good night and thank you for your time and patience! I will be adding a LinkedIn recommendation later as well. Clapping HandsClapping HandsClapping HandsClapping Hands

negar-75 commented 1 year ago

thanks @XanderRubio for your informative text and I appreciate it, Now I am going to create another merge request for auto translation

XanderRubio commented 1 year ago

thanks @XanderRubio for your informative text and I appreciate it, Now I am going to create another merge request for auto translation

Great @negar-75 and my pleasure!