BeforeIDieCode / BeforeIDieAchievements

🌟An open source project that helps developers make their first pull request and contribute to open source projects. πŸš€πŸŽ― Developers can contribute by sharing what they want to do before they die. πŸ’‘πŸ”—
https://before-i-die-achievements.vercel.app
MIT License
117 stars 184 forks source link

Fix: Issue #77, Automatically Centered Contributer's Text #85

Closed Angeltheesoto closed 1 year ago

Angeltheesoto commented 1 year ago

I'm sorry that it looks like a lot changed but its mostly just empty spaces and VsCode auto formatting the code. The only change I made was adding a style tag that automatically center contributer's text that are fifty or less characters long. I also noticed that I could of simply changed the width to equal 100% but I wasn't sure to do that, as that wouldn't have gone with the explained solution you asked in the issue.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
before-i-die-achievements βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 14, 2023 8:23pm
XanderRubio commented 1 year ago

I'm sorry that it looks like a lot changed but its mostly just empty spaces and VsCode auto formatting the code. The only change I made was adding a style tag that automatically center contributer's text that are fifty or less characters long. I also noticed that I could of simply changed the width to equal 100% but I wasn't sure to do that, as that wouldn't have gone with the explained solution you asked in the issue.

Hi @Angeltheesoto,

I am currently reviewing your pull request, but I have noticed that another contributor had submitted a pull request before you on the same issue of centering the text. I apologize for not being quick enough in assigning a contributor for issue #77. I will review their pull request first and provide you with an update as soon as possible.

XanderRubio commented 1 year ago

This pull request successfully closes out issue #77. Congratulations @Angeltheesoto for your pull request merged into the main branch Clapping Hands

XanderRubio commented 1 year ago

AlienIn the future, to prevent multiple contributors from working on the same open issue, please ensure that you have been assigned to the issue before starting work on it. Thank you, @Angeltheesoto!

Angeltheesoto commented 1 year ago

Thank you @XanderRubio, I'll make sure to ask to be assigned next time. πŸ™

XanderRubio commented 1 year ago

Thank you @XanderRubio, I'll make sure to ask to be assigned next time. πŸ™

Thak you Angel!