search

Befox / cdav

Dolibarr module to access calendars and address book from CalDAV/CardDAV tools
GNU General Public License v3.0
47 stars 28 forks source link

Why put SabreDav in lib inside the module as Dolibarr already include SabreDav ? #52

Closed FHenry closed 1 month ago

FHenry commented 1 year ago

Why put SabreDav in lib inside the module as Dolibarr already include SabreDav ?

cfoellmann commented 1 year ago

I suspect that @FHenry has issues with the very outdated version included in Dolibarr

FHenry commented 1 year ago

Why do not make a pr in dolibarr to upgrade it ?

cfoellmann commented 1 year ago

you can try but it would only be updated in the next release of Dolibarr and the devs are not open to using composer like it should be used.

cfoellmann commented 1 year ago

Since dolibarr is going for php >= 8.0 I would send a PR for SabreDav to dolibarr if @jpfox is open for using the included version

jpfox commented 1 year ago

When cdav was written, in first versions, sabre/dav was not included into Dolibarr. I discover it with your message. Maybe in a future release, cdav will use embedded version of SabreDAV :-)

cfoellmann commented 1 year ago

So let me send a PR for SabreDav 4.4.0 to dolibarr core?

17.0 will be ready soon so the update might be perfect for the next development cycle.

FHenry commented 1 year ago

at least in version 18.0 sabredav is upgrade to 4.5.1 https://github.com/Dolibarr/dolibarr/pull/24898/files#diff-aa6b3e61abceef63b8298be436d830ed58670f126812dfb028f1094cc238de79

FHenry commented 1 month ago

I close the issue, as the PR https://github.com/Befox/cdav/pull/56 is open in waiting to be merged