search

Begad666 / cps

Advanced ServerList and Maintenance plugin
https://www.spigotmc.org/resources/customprotocolsettings.69385/
MIT License
2 stars 0 forks source link

Bug Found Playercount does not report correctly with RedisBungee #19

Closed MastoryMd5 closed 3 years ago

MastoryMd5 commented 3 years ago

I might be particularly unlucky but i found another small bug with CPS.

2401e3dc0472d0eb300098e8f9bfca24

The server on the top is using CPS the server on the bottom is using cleanmotd

As you can see i don't get the same playercount, actually the server with CPS gives the playercount of the single proxy not of all the proxies connected with redisbungee

Begad666 commented 3 years ago

So I need to add redisbungee support and change how the plugin sends player counts and possibly, player names if enabled.

Begad666 commented 3 years ago

I think I have done the integration but if you can check it out use this version. CustomProtocolSettings.zip

.

Begad666 commented 3 years ago

And also a new way to get ping from other servers. Just enable settings.ping-unstable-redisbungee .

MastoryMd5 commented 3 years ago

Perfect, the patch works amazingly!

Begad666 commented 3 years ago

Nice, now I should make the other things to use RedisBungee and that will be it. And what about the ping command?

MastoryMd5 commented 3 years ago

The ping works but i have to test it to see if it's actually "unstable"

Begad666 commented 3 years ago

That's good

MastoryMd5 commented 3 years ago

Okay actually the ping works on the same bungeecord but if i'm on one proxy and the player is in another proxy i can't ping the player and when i send the command i don't get an answer

Begad666 commented 3 years ago

That's probably because it doesn't process the message right, gotta check the problem.

Begad666 commented 3 years ago

Try this and check all the consoles. This one will send debug messages. CPS.zip

MastoryMd5 commented 3 years ago

Proxy 1 i do the command with my account, on the console nothing appears. Proxy 2 the console receives the command to get the ping for the player but no message appears [CustomProtocolSettings]: Received command to get ping for NullTheElif

Begad666 commented 3 years ago

Check the server id for proxy 1, if it matches the log output, I will need to install redis to debug it. CPS2.zip

MastoryMd5 commented 3 years ago

Proxy 2 i do the command with my account, on the console nothing appears. Proxy 1 Console[CustomProtocolSettings]: Received command to get ping for NullTheElif

Proxy 2 console [CustomProtocolSettings]: Received ping result for java2, id NullTheElif

Proxy 1 is java1 and Proxy 2 is java2

MastoryMd5 commented 3 years ago

I've switched proxy but it should be the same

Begad666 commented 3 years ago

java2 is your proxy 1 id right?

Begad666 commented 3 years ago

nvm

Begad666 commented 3 years ago

This one should work, messed up the indexes. CPS3.zip

MastoryMd5 commented 3 years ago

Now i get this error https://hastebin.com/wupojoguco.properties

Begad666 commented 3 years ago

I am sorry but this should be the last time. NPEFix.zip

MastoryMd5 commented 3 years ago

e81b96fa53b9ee1ebff1f0560c35ada7 It works!

Begad666 commented 3 years ago

"Perhaps", I mean, it might glitch if too many users are using the command, didn't test it, if it doesn't glitch, then I might remove the unstable and just ping-redisbungee-support

Begad666 commented 3 years ago

But for now, I think it finished

Begad666 commented 3 years ago

And a quick thing, reloading breaks redisbungee integration, just saw it now, will get fixed.