search

Behat / Behat

BDD in PHP
http://behat.org
MIT License
3.9k stars 612 forks source link

Table transformation with umlauts #1106

Open UFOMelkor opened 6 years ago

UFOMelkor commented 6 years ago

I tried to make a table transformation with column names that contains german umlauts. Sadly my transformation are not applied.

As a modified example from the features:

/** @Transform table:username,äge */

would not be applied for this table:

          Given I am user:
            | username | äge |
            | ever.zet | 22  |

It would work if the modifier u is added to the pattern regex: /^table\:(?:\*|[[:print:]]+)$/u but I'm not deep enough on topic to know about possible side effects …

everzet commented 6 years ago

Thanks for reporting!

mnofresno commented 2 years ago

Hi! I've created this PR to solve this issue, but I was unable to make the tests fail, the new added test always passing regardless the age number matches or not.

I've added a @mariano tag to my newly created tests so I ran them using this command:

$ bin/behat --format=progress  --tags '@mariano'

Please help me I want to start contribuiting to this project.

Thanks!

ciaranmcnulty commented 2 years ago

IT looks like your Pr is being overlooked because it's not to this repo

mnofresno commented 2 years ago

I know it's not to this repo, I've asked a question I need to solve before creating the definitive PR.