search

Behat / Gherkin

Gherkin parser, written in PHP for Behat project
MIT License
1.05k stars 89 forks source link

Refactor the parsing of comments to avoid recursion #204

Closed stof closed 3 years ago

stof commented 3 years ago

Closes https://github.com/Behat/Gherkin/pull/138 (the first commit adding a test is the one from this PR)

stof commented 3 years ago

I tested locally and this indeed makes the test pass with xdebug enabling the limit.

stof commented 3 years ago

@ciaranmcnulty I don't know what is the state of #178 yet, but it might make sense to include that fix in a 4.7.3 release.

ciaranmcnulty commented 3 years ago

Nice work @stof, thank you