search

Behat / Gherkin

Gherkin parser, written in PHP for Behat project
MIT License
1.05k stars 89 forks source link

Feature description whitespace does not match Cucumber #209

Open ciaranmcnulty opened 3 years ago

ciaranmcnulty commented 3 years ago

We just seem to trim it slightly differently

Removing this line will add a failing test https://github.com/Behat/Gherkin/blob/master/tests/Behat/Gherkin/Cucumber/CompatibilityTest.php#L39

ciaranmcnulty commented 3 years ago

Would fixing this be a BC break? We can make a new method that returns the description with the same whitespace as cucumber but that seems over the top. Do people depend on this for something or do they blindly trim it?

ciaranmcnulty commented 3 years ago

I'm almost tempted to WONTFIX this. Our version's better :)

stof commented 3 years ago

I suggest discussing that with cucumber