search

Behat / Gherkin

Gherkin parser, written in PHP for Behat project
MIT License
1.05k stars 89 forks source link

Wrong hash for cucumber releases? #223

Closed ciaranmcnulty closed 3 years ago

ciaranmcnulty commented 3 years ago

We get the list by running 

git ls-remote --tags https://github.com/cucumber/cucumber.git

Which looks like:

580f185fb19285e42373c4cb2a88a8de66b308a3        refs/tags/cucumber-gherkin/v17.0.1
99706895df020c8d005bc6d32afe2fec691b8493        refs/tags/cucumber-gherkin/v17.0.2

And use that hash for the cucumber update.

However, when I look into the Github UI, that hash seems to be of the previous commit?

Screenshot 2021-02-17 at 10 34 48

So we are potentially getting the wrong hash. The cucumber release process means this is only missing a changeling and some version numbers, but could be quite dangerous in future if unresolved

stof commented 3 years ago

this is due to how tags are done in the cucumber repo: image

they have 2 different tags on different commits

stof commented 3 years ago

I would say that this is probably a glitch on the cucumber side. I don't see why this would be intended.

ciaranmcnulty commented 3 years ago

Aha so it should be a simple fix, thank you

stof commented 3 years ago

well, the question is whether we even need to change something. the cucumber-gherkin/* tags are the one they use for the github releases.

ciaranmcnulty commented 3 years ago

They don't contain the changelogs and I wanted to get that into the PR

ciaranmcnulty commented 3 years ago

From what I can see, they release cucumber-gherkin which then prompts cukebot to update and sync a load of stuff, which tags gherkin and manages the subrepo stuff?