A suggestion - Githubissues

Behat / MinkExtension

Mink extension (tight integration and configuration) for Behat

MIT License

636 stars 279 forks source link

A suggestion #259

Open jorgealonso78 opened 7 years ago

jorgealonso78 commented 7 years ago

` /**

@Given I am on :urlPath
@When I go to :urlPath
@Given I am on home page
@When I go to home page */ public function visit($urlPath="/") { $this->visitPath($urlPath); }`

aik099 commented 7 years ago

This better to be sent as a Pull Request right away.

jorgealonso78 commented 7 years ago

Okay but I don't have time right now for clone the repo, create a branch,make the change and create the pull request. If the suggestion is take maybe someone else can do it (a more active contributor)

spolischook commented 7 years ago

You can just edit on GitHub. How ever I didn't like that, because this steps already implemented in my Context, so after update I'll need to fix this.

aik099 commented 7 years ago

Aren't there any steps already that call visit or visitPath?

jorgealonso78 commented 7 years ago

thk @spolischook I di not know that I can do the change over the GitHub I did my suggests changes in https://github.com/Behat/MinkExtension/pull/260