search

Behat / MinkExtension

Mink extension (tight integration and configuration) for Behat
MIT License
636 stars 279 forks source link

Marionette capability should be optional #377

Open andrewnicols opened 2 years ago

andrewnicols commented 2 years ago

The marionette capability is a Firefox-specific capability to aid in the transition from legacy versions of Firefox (47.0.1 and earlier).

It is a Boolean and this value is now checked aggressively in Selenium 4.0.0 onwards. Since null is not a Boolean, this leads to an error.

This patch removes the default value, which means that if no value is specified then it will not be included in the output, and the defaults will apply (True for Firefox; Unset for other browsers).

Without this patch you must jump through hoops to run against Selenium 4.

Fixes #376

andrewnicols commented 2 years ago

@stof, Any chance of a review on this? This is a bit of deal breaker for anyone using Selenium 4 with Chrome, and Selenium 3 is no longer maintained (3.15 came out in August 2019).

Chekote commented 2 years ago

@andrewnicols I ran into this problem too, along with a bunch of other issues. This repo seems to not be getting much attention. I recommend you switch to https://github.com/FriendsOfBehat/MinkExtension which has already fixed this problem.