Closed sroze closed 6 years ago
👍
@sroze could you please create a release?
It's introducing a same BC break in this extension - https://github.com/symfony/symfony/issues/27494.
What do you mean?
On Wed, Jun 6, 2018 at 7:55 AM Kamil Kokot notifications@github.com wrote:
It's introducing a same BC break in this extension - symfony/symfony#27494 https://github.com/symfony/symfony/issues/27494.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Behat/Symfony2Extension/pull/139#issuecomment-394960916, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxHEVLHubp1j4xCLR4zgMSPb74Ot_ODks5t53z-gaJpZM4TLozw .
for anyone using a custom container based class for their main container, the container injected here is not the custom one anymore (as it is the test container).
So we would have to expose this in a different way
actually, as it is used only in the argument resolver, I don't think it suffers from the BC break
Yeah, if it's used as only as an argument resolver, then it wouldn't be a BC break indeed.
so a release could be done, as it is no BC break?
ping @sroze
Thank you 🎉
In Symfony 4.1, we (actually, @nicolas-grekas) added the ability to get private services from the container (https://github.com/symfony/symfony/pull/26499). We need to leverage this within Behat's extension.