Behat / Symfony2Extension

Symfony2 extension for Behat
MIT License
393 stars 106 forks source link

Uses the test container if exists #139

Closed sroze closed 6 years ago

sroze commented 6 years ago

In Symfony 4.1, we (actually, @nicolas-grekas) added the ability to get private services from the container (https://github.com/symfony/symfony/pull/26499). We need to leverage this within Behat's extension.

jakzal commented 6 years ago

👍

OskarStark commented 6 years ago

@sroze could you please create a release?

pamil commented 6 years ago

It's introducing a same BC break in this extension - https://github.com/symfony/symfony/issues/27494.

sroze commented 6 years ago

What do you mean?

On Wed, Jun 6, 2018 at 7:55 AM Kamil Kokot notifications@github.com wrote:

It's introducing a same BC break in this extension - symfony/symfony#27494 https://github.com/symfony/symfony/issues/27494.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Behat/Symfony2Extension/pull/139#issuecomment-394960916, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxHEVLHubp1j4xCLR4zgMSPb74Ot_ODks5t53z-gaJpZM4TLozw .

stof commented 6 years ago

for anyone using a custom container based class for their main container, the container injected here is not the custom one anymore (as it is the test container).

So we would have to expose this in a different way

stof commented 6 years ago

actually, as it is used only in the argument resolver, I don't think it suffers from the BC break

pamil commented 6 years ago

Yeah, if it's used as only as an argument resolver, then it wouldn't be a BC break indeed.

OskarStark commented 6 years ago

so a release could be done, as it is no BC break?

OskarStark commented 6 years ago

ping @sroze

sroze commented 6 years ago

Released in 2.1.5.

OskarStark commented 6 years ago

Thank you 🎉