search

Behat / Symfony2Extension

Symfony2 extension for Behat
MIT License
393 stars 106 forks source link

Support symfony 5 #155

Closed gabfr closed 4 years ago

gabfr commented 4 years ago

I know there is already the PR #152 to add support for symfony v5, but it seems abadoned, and since I'm in need I did this PR with mine and @larzuk91 commits, also with some modifications suggested in the #152 discussions too.

gabfr commented 4 years ago

It seems that we'll have to wait for behat/behat support of symfony v5 components, moreover, the merge of this PR (https://github.com/Behat/Behat/pull/1256) .

piotrbrzezina commented 4 years ago

any news about this PR ?

gabfr commented 4 years ago

I ended up not using this extension anymore in my project. It’s quite simple to remove its usage.

I can’t disclosure the source of my project, but if you need any help, just reach me on my email or linkedin.

alexander-schranz commented 4 years ago

@gabfr do you maybe have some gist where you did remove the extension. I'm sadly not familiar with behat and try to update a bundle which currently use it.

verschoof commented 4 years ago

https://github.com/Behat/Behat/pull/1256 has been merged, can you rerun the tests?

gabfr commented 4 years ago

@verschoof sorry, It seems we have a problem with the PHPUnit version. I'm in a hurry now. I'll take some time to look into it.

@alexander-schranz sure. I'll do a gist with the changes asap!

alexander-schranz commented 4 years ago

@gabfr would be great if you could provide a gist. I will have a look at the PHPUnit version problem!

gabfr commented 4 years ago

@alexander-schranz here you are: https://gist.github.com/gabfr/65cbfedefe7dbfcbc9606677acb437d9

alexander-schranz commented 4 years ago

@gabfr Thank you did work for me! The changes I needed to do can be found here maybe it helps somebody: https://github.com/massiveart/MassiveSearchBundle/pull/139/files