search

Behat / Transliterator

Behat Transliterator library inherited from Doctrine1 and used in Behat for snippet generation
Other
2.05k stars 30 forks source link

Data in bankfiles #1

Closed WouterSioen closed 10 years ago

WouterSioen commented 10 years ago

Is there a reason the data in the bankfiles isn't the same as in the original code? http://cpansearch.perl.org/src/SBURKE/Text-Unidecode-0.04/lib/Text/Unidecode/

Only the files x00 - x07 seem to be the same. Because of some empty files and some missing items, Chinese and Japanese characters can only be partially transliterated.

WouterSioen commented 10 years ago

Maybe @l3pp4rd knows more about this? Since he commited this first in his DoctrineExtensions.

WouterSioen commented 10 years ago

Any news about this? We're experiencing problems with some Chinese signs because of this. If the data banks need to be changed to the data in the original files (http://cpansearch.perl.org/src/SBURKE/Text-Unidecode-0.04/lib/Text/Unidecode/), I'm willing to create a pull request.

stof commented 10 years ago

hmm, many files are currently using [?] as transliteration rather than the perl one (see x52 doe instance).

I think it could be worth updating them with the real transliteration. If you want to work on it, a PR would indeed be welcome.

stof commented 10 years ago

@WouterSioen any news ?

WouterSioen commented 10 years ago

Hi @stof, I'll try to look at it this week. I was on holiday the last two weeks.

everzet commented 10 years ago

@WouterSioen no prob. But if you indeed could look into it, it would be extremely awesome :)

stof commented 10 years ago

yeah indeed, no problem. Holydays are important :smile: