search

Behat / Transliterator

Behat Transliterator library inherited from Doctrine1 and used in Behat for snippet generation
Other
2.05k stars 31 forks source link

Use Symfony code style #16

Closed peter-gribanov closed 4 years ago

peter-gribanov commented 7 years ago

Fix errors of Symfony code style

stof commented 7 years ago

data files are auto-generated. So they must not be modified by hand

peter-gribanov commented 7 years ago

@stof i add data folder to ignore list

everzet commented 7 years ago

First, thanks for contribution! That said, I struggle to see the value this change brings. Can you elaborate on why do you believe this change is necessary and who's life it makes easier?

peter-gribanov commented 7 years ago

@everzet you want me to explain what the code style is and what is the benefit of enforcing it?

everzet commented 7 years ago

Yes, except not in general, but in the context of this particular project.

peter-gribanov commented 7 years ago

Strange question

CS it's not a feature. CS is needed to improve the readability of the code. First of all, it is needed for contributors.

Do you want to receive help from other developers? Do you want PR to be readable?

If Yes, then you need control over CS.

peter-gribanov commented 7 years ago

@everzet Кость, а чем тебе собственно не нравится идея контроля за CS?

everzet commented 4 years ago

This is super late answer, but I will provide it anyway, in case someone else has the same question.

None of the current repository maintainers is logic/code maintainers of this repository. This repo was created as a copy-paste of the logic to Packagist with basic QA automation via Travis.

Simply put - we maintain builds and Composer packages, but not the codebase. If I had any desire to maintain the codebase, I'd establish a CS and refactor 90% of the code here, but I don't have any desire. My objective is actually the opposite - to do as little changes to this codebase as humanly possible.

If someone wants to take over maintenance of both this repo build pipeline AND codebase, I am happy to discuss :)

Hope this clarifies.

P.S. @peter-gribanov sorry for a very late answer. It's not out of disrespect. Life gets in the way.