search

Behat / Transliterator

Behat Transliterator library inherited from Doctrine1 and used in Behat for snippet generation
Other
2.05k stars 31 forks source link

Update bank files - Fixes #1 #2

Closed WouterSioen closed 10 years ago

WouterSioen commented 10 years ago

This pull request updates the bank files to mirror the files in the original implementation (http://cpansearch.perl.org/src/SBURKE/Text-Unidecode-0.04/lib/Text/Unidecode/)

stof commented 10 years ago

hmm, so the Asian chars were totally wrong ?

WouterSioen commented 10 years ago

Since this is a port from the perl version, I assume the perl version is correct. I don't have any knowledge of Asian languages, so I can't check this.

WouterSioen commented 10 years ago

Maybe @l3pp4rd knows more about this, since he ported this implementation to PHP in his DoctrineExtensions.

stof commented 10 years ago

Can you fix the escaping issues ?

WouterSioen commented 10 years ago

I'll check it.

WouterSioen commented 10 years ago

I fixed some escaping issues, but I'll have to check some items with a lot of escaping characters and quotes (like in bankfile x1f.php).

stof commented 10 years ago

@WouterSioen I'm doing a review of all files currently, to see if I spot stuff you forgot. No need to fix immediately, you can wait until I'm done to do it in a single pass instead

WouterSioen commented 10 years ago

Ok, I'll wait for fixing your upcoming comments.

stof commented 10 years ago

OK, done

WouterSioen commented 10 years ago

Fixed

stof commented 10 years ago

Thanks @WouterSioen.