Support php versions from 5.7 to 7.4

[everzet]

Primarily a rebase of #26 and removes the need in #27

[snapshotpl]

@everzet looks good. 🛳

[rpkamp]

PHP 7.4 was released yesterday. If Travis already supports it than that should be used instead of 7.4snapshot.

[Pierstoval]

What needs to be done to finish this PR? Any help needed?

[kuraobi]

Are we waiting for Travis to add PHP7.4 final binary? Is it any different than the latest 7.4snapshot?

[pfazzi]

Come on guys, this deprecation warning is still annoying me every time a clear my app cache :smile:

[kuraobi]

FYI PHP7.4 is available in Travis CI for Ubuntu 18.04. Is there any reason to stick to 14.04?

[kdambekalns]

Please merge this, PHP 7.4 support would be awesome!

BTW, I tested this and it works fine.

[snapshotpl]

@everzet travis now contains stable 7.4 so we are ready to go!

[Pierstoval]

I used this in my composer.json file:

    "require": {
...
-        "behat/transliterator": "^1.2",
+        "behat/transliterator": "dev-support-php74 as 1.2.x-dev",
...
+    "repositories": [
+        {
+            "type": "vcs",
+            "url": "https://github.com/Behat/Transliterator"
+        }
+    ],

My 647-tests suite with good coverage on my biggest project is all green 😉

All that needs to be fixed is the Travis build, I guess 🤔

[kdambekalns]

Small tweak suggestion: Change the PR title to "Support php versions from 5.6 to 7.4" :)

Also, pleeeeaaaase get this merged and released! ❤️

[kdambekalns]

One more comment from me: with a simple dist:bionic for the PHP 7.4 build it works, as can be seen on https://travis-ci.org/kdambekalns/Transliterator/builds/621004013

[alexander-schranz]

@kdambekalns 7.4 is now also available on trusty so just a CI restart should make it green.

[kuraobi]

Any news on this? What's preventing the merge of #30 and this one? For now we use branch aliases but I'm not a fan of having branch aliases in production, and I don't think that's a solution for the 15.8K+ downstream projects to support PHP7.4. So if there is anything else to do, please let us know.

[kdambekalns]

🎉

[kdambekalns]

Hooray to this being merged, any reason not to release a new version now?

[TomasVotruba]

Release would be great, it breaks our build now :/ https://travis-ci.org/KnpLabs/DoctrineBehaviors/jobs/624044738#L371

[alexander-schranz]

@stof is there something we can do to help to move the release forward?

[snapshotpl]

@everzet @stof missing release of this lib is really annoying for many important projects in php community. Can you move forward this?

[TomasVotruba]

Solution: https://github.com/KnpLabs/DoctrineBehaviors/pull/468/files#diff-c5f7d7b9e0f14fa580860143f56f3b7f

Works great :+1:

[kdambekalns]

This is getting less funny by the day.

• A lot of libraries (95 says Packagist) out there depend on this package, among them well-known players like (ahem) behat/behat and gedmo/doctrine-extensions.
• PHP 7.4 has meanwhile seen it's first patch-level release.
• Compatibility is ensured with this PR, which has been merged 10 days ago.
• Multiple people asked for this to get some attention and/or asked how they could help.
• First projects switched to symfony/strings instead of this one, even though it still is "experimental"

All that is needed to fix this mess would be a new release, something that takes three clicks (counting from https://github.com/Behat/Transliterator) and a tiny bit of typing.

Please. Help. The. PHP. Community!

[nocive]

@kdambekalns thank you for voicing our concerns :bowing_man: :medal_sports:

[nocive]

@kdambekalns release has been released! :)

[kdambekalns]

@kdambekalns release has been released! :)

Yes, I know. And we released our depending project as well. So, all set. Just wondering why https://github.com/Behat/Transliterator/issues/25 is still open. But… whatever.

And let's hope the feeling of "staleness" won't come back again…