search

Behat / Transliterator

Behat Transliterator library inherited from Doctrine1 and used in Behat for snippet generation
Other
2.05k stars 30 forks source link

Russian letter 'e' translation #9

Closed aur1mas closed 8 years ago

aur1mas commented 8 years ago

As addressed on #4 issue, there is a problem with Russian 'e' letter conversion to latin.

Examples would be with - тест (word), Брест (city in Belarus).

In order to fix this issue, I had to modify current test examples with Russian words.

To prove that my assertions were correct I've used online transliterator tools such as http://translit-online.ru/ & http://translate.google.com.

So phrase това е тестово заглавие with online transliterator would be tova e testovo zaglavie.

transliterator

g_transliterator

I would presume that older russian test cases were written no by russian guy :)

Thank you for reviewing my PR & if you have any questions or should do anything else - please write.

BoShurik commented 8 years ago

+1 Moreover, in bulgarian it is also incorrect: http://bg.translit.cc/ "това е тестово заглавие" => "tova e testovo zaglavie"

stof commented 8 years ago

Transliteration data are taken from the Perl library, and we have an automated tool to synchronize them now, so I won't accept manual changes to the data files (as they would get lost on the next sync anyway).

aur1mas commented 8 years ago

So I think this PR is useless...

@BoShurik I would suggest https://github.com/cocur/slugify/ as it handles transliteration internaly. (so PRs can be accepted).