search

Behat / WebApiExtension

Behat extension to test web APIs
http://extensions.behat.org
MIT License
111 stars 114 forks source link

Guzzle 6 support #35

Closed soullivaneuh closed 8 years ago

soullivaneuh commented 8 years ago

Closes #30.

This PR keeps Guzzle 4 and 5 support.

I think Travis should be updated to test each major version of Guzzle, what do you think?

soullivaneuh commented 8 years ago

PR finished.

soullivaneuh commented 8 years ago

@stof review fixed.

soullivaneuh commented 8 years ago

@stof I would like to fix following errors: https://travis-ci.org/Behat/WebApiExtension/jobs/83917614#L259

But I can't run the server:

$ ./bin/start_server.sh 
touch: cannot touch ‘/server.log’: Permission denied
soullivaneuh commented 8 years ago

Errors are only on the theResponseShouldContainJson method, but I don't get what wrong things I did...

Any idea?

soullivaneuh commented 8 years ago

@stof Travis is green! :green_heart:!

PR ready to merge.

soullivaneuh commented 8 years ago

@stof review fixed.

soullivaneuh commented 8 years ago

@stof done.

soullivaneuh commented 8 years ago

@stof done.

soullivaneuh commented 8 years ago

@stof Maybe we could use webmozart/json for json decode?

joshhornby commented 8 years ago

Can this be merged?

soullivaneuh commented 8 years ago

For me, this PR is ready to merge.

soullivaneuh commented 8 years ago

ping @stof could you please merge it?

adrienbrault commented 8 years ago

@stof What is missing here ?

joshhornby commented 8 years ago

@stof Any update?

soullivaneuh commented 8 years ago

PR rebased with resolved conflicts (composer.json).

kallosz commented 8 years ago

up

teriu commented 8 years ago

+1

zazoomauro commented 8 years ago

+1