search

Behat / docs

Behat documentation repository
http://behat.org
28 stars 69 forks source link

chore: add github action that builds the site and checks the build #167

Closed carlos-granados closed 2 weeks ago

carlos-granados commented 2 weeks ago

Fixes https://github.com/Behat/docs/issues/160

carlos-granados commented 2 weeks ago

@acoulton I created this PR but it seems that actions are not enabled for this repo 😞. It worked on a test a did on my fork. I guess we will need @everzet to enable actions here. Unless you can think of any other reason why this won't run here

carlos-granados commented 2 weeks ago

@acoulton I created this PR but it seems that actions are not enabled for this repo 😞. It worked on a test a did on my fork. I guess we will need @everzet to enable actions here. Unless you can think of any other reason why this won't run here

Mmm, it is weird, if actions were disabled then the Actions tab would not show 🤔

stof commented 2 weeks ago

When adding a new workflow in a PR, it won't run for PRs coming from a fork (as there is no workflow triggered on PRs in the repo being the target of the PR)

carlos-granados commented 2 weeks ago

Ah, yes, of course. And this is not the first time I have had this... 🤦

carlos-granados commented 2 weeks ago

This is the workflow run in my fork: https://github.com/carlos-granados/behat-docs/actions/runs/11726804170

stof commented 2 weeks ago

Adding a new workflow is a case where it is simpler to put the feature branch in the main repo rather than contributing from a fork.

acoulton commented 2 weeks ago

The file itself looks good at a scan, if it is working in your fork I suggest we merge it and hopefully that should trigger a first run - as @stof says I think it's just because it's new.

Either it will go green or nothing will happen so no major issue merging IMO 🤣

carlos-granados commented 2 weeks ago

It did not work because the main brach here is not master 🤦 Let me add a fix