Behatch / contexts

Behat extension with most custom helper steps
Other
393 stars 203 forks source link

Typo in RestContext #239

Closed ilovemistakes closed 6 years ago

ilovemistakes commented 6 years ago

There is @Then the response should be equal to definition in src/Context/RestContext.php:84. It is used in tests/features/rest.feature:86. But there is <source>the response should be equal to:</source> in i18n/en.xliff.dist, which does not correspond to the actual defintion because of a colon. I am currently creating translations for russian, and my tests/features/ru/rest.feature is failing because of that missing colon. Other existing translations have no tests for this definition at all. What should I do? Strip colon from i18n/ru.xliff and tests/features/ru/rest.feature to make it pass? Should I also strip colon from i18n/en.xliff.dist? Is this definition supposed to be inconsistent with other should equal to: definitions (e.g. @Then the JSON should be equal to:)?

ilovemistakes commented 6 years ago

Fixed in #241