No Input/output port order anymore in writeTreeNodesModelXML ?

BehaviorTree / BehaviorTree.CPP

Behavior Trees Library in C++. Batteries included.

https://www.behaviortree.dev

MIT License

3.03k stars 665 forks source link

No Input/output port order anymore in writeTreeNodesModelXML ? #851

Open RhysMcK opened 3 months ago

RhysMcK commented 3 months ago

Hi,

I notice in this commit d5ea17b5184feacac3f3763de0730713384bafc9 you removed the input/output port ordering logic. As a result, when using writeTreeNodesModelXML() to auto-generate the <TreeNodesModel> tags for Groot2, the ports are in some ?random? order. This is than obviously reflected in Groot2 and not ideal. What was the rational behind removing this?

Thanks very much!

facontidavide commented 1 month ago

The correct solution, in my opinion, is to presere the order of the ports as it was described in providedPorts.

Unfortunately, this means that we need to apply a change that breaks the API / ABI.

In the meantimes, can you test the changes here: #870