Beit-Hatfutsot / dbs-back

The MoJP RESTfull API server
GNU Affero General Public License v3.0
1 stars 4 forks source link

Vainstein - Forbes Syndrome (name difference between search result and person in tree) #20

Closed TheGrandVizier closed 7 years ago

TheGrandVizier commented 7 years ago

From @TheGrandVizier on July 13, 2016 8:36

A search result on this page: http://dbs.bh.org.il/person?last_name=vainstein name Jacobo Vainstein, when clicked on, magically turns into a Paul Forbes. The rest of the data is unchanged - the tree number matches between the result and the inside of the tree. The daughter is still Amy.

I will add more URLs with similar cases that match the syndrome as i find them.

Copied from original issue: Beit-Hatfutsot/dbs-front#158

TheGrandVizier commented 7 years ago

From @daonb on August 31, 2016 12:25

The gedom we have for this tree is a bit different than the one that was loaded into BHP. Our migration process merges info from the BHP and from a parsed Gedcom and that's why we find details from two different individuals in the same person.

Let's examine Jacobo/Vainstein/Paul Frobes as a n example. Based on the url - http://dbs.bh.org.il/person/231/I0339 - we know it's person id I0339 in tree number 231. Looking at PHP the name of this person is Jacobo Vainstein, but in the gedcom file it's Paul Forbes.

I can think oif two causes for this issue:

As Haim assured me they never edit family trees, I assume we've been using outdated gedcom files.

I am now looking for a fresher version of the file.

TheGrandVizier commented 7 years ago

From @daonb on August 31, 2016 12:36

Found that this specific tree has 4 versions: from 2006, 2007,2008 an done from 2010. The one we're parsing as part of the migration is the one from 2006 :-(

TheGrandVizier commented 7 years ago

This bug has another representation. It is also possible to get bad and irrelevant search results. A good example is searching in family trees for the last name "Falic". This brings up multiple results, all from the same tree, but the absence of a "falic" as last name is very clear.