Beit-Hatfutsot / dbs-back

The MoJP RESTfull API server
GNU Affero General Public License v3.0
1 stars 4 forks source link

free text linkify should work on new (clearmash) infrastructure #212

Open OriHoch opened 7 years ago

OriHoch commented 7 years ago

reproduction

expected

actual

notes

OriHoch commented 7 years ago

fixed and deployed to dev

TheGrandVizier commented 7 years ago

It works, but takes a very very long time. Do we expect the links to show up on Nirs pages with a delay after loading the page?

@nirgoldberg @nuritgazit

nuritgazit commented 7 years ago

no, we expect them to appear when the pages load

nirgoldberg commented 7 years ago

@OriHoch, for some reason this feature stopped working. Can you take a look at that?

OriHoch commented 7 years ago

we recently reverted back to old version of the code - before Clearmash changes

IIRC this feature was implemented on the new architecture - which doesn't exist anymore..

@nirgoldberg do you know when this stopped working? we reverted back to old architecture around Sep 12

If my assumption is correct that it never worked on the old architecture - then I guess it will take a few hours work to adjust or re-develop this feature for the old architecture (if there aren't any unexpected problems)

@nuritgazit please approve this work

OriHoch commented 7 years ago

this is the url on production environment (We don't have dev anymore): https://api.dbs.bh.org.il/v1/linkify?html=hello%20from%20germany

looks like indeed it's just not there (returns 404)

nuritgazit commented 7 years ago

@OriHoch approved

OriHoch commented 6 years ago

fixed and deployed (it's still slow and buggy as it was...)