search

Beit-Hatfutsot / dbs-back

The MoJP RESTfull API server
GNU Affero General Public License v3.0
1 stars 4 forks source link

Case where an item cannot be clicked via general #84

Closed TheGrandVizier closed 7 years ago

TheGrandVizier commented 7 years ago

From @TheGrandVizier on January 3, 2017 8:44

When searched in the General Search, this item cannot be clicked.

Repro:

  1. Search for Georgia in general search.
  2. Click the search result for Georgia. Result: The result is not clickable.

Copied from original issue: Beit-Hatfutsot/dbs-front#259

TheGrandVizier commented 7 years ago

Another item that falls in this category is Biel.

TheGrandVizier commented 7 years ago

From @Inna-r on January 23, 2017 13:33

@TheGrandVizier results for Georgia and Biel are actually clickable. Some other examples?

daonb commented 7 years ago

Sounds to me like a problem with the ES data. IMO, resetting the data solved the issue.

TheGrandVizier commented 7 years ago

This is still alive on production, @daonb @OriHoch

OriHoch commented 7 years ago

I'll have a look

OriHoch commented 7 years ago

I did a quick fix for this problem by generating slug on the fly in case it doesn't exist in elastic search results

this will fix it for this case, and also, in general I think it's a good idea to do it because maybe there are more cases like this.

For the long-term I opened an issue #128 - to add a script that will ensure correct slugs

TheGrandVizier commented 7 years ago

It is my understanding benny already has such script. And yes, the effects are far reaching. Georgia and biel are just examples.

On Mar 21, 2017 1:12 PM, "Ori Hoch" notifications@github.com wrote:

I did a quick fix for this problem by generating slug on the fly in case it doesn't exist in elastic search results

this will fix it for this case, and also, in general I think it's a good idea to do it because maybe there are more cases like this.

For the long-term I opened an issue #128 https://github.com/Beit-Hatfutsot/dbs-back/issues/128 - to add a script that will ensure correct slugs

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Beit-Hatfutsot/dbs-back/issues/84#issuecomment-288047266, or mute the thread https://github.com/notifications/unsubscribe-auth/AOfPtYeU5h4gCp5v_vfJP-7geyVeCT42ks5rn7CYgaJpZM4L05AQ .

OriHoch commented 7 years ago

the short-term fix was deployed to production, it should fix all cases where elasticsearch doesn't have the slug but mongo has the slug..

@TheGrandVizier - please test and see if you can find more cases (I couldn't find any..)