search

Beit-Hatfutsot / dbs-front

Frontend code for http://dbs.bh.org.il
GNU Affero General Public License v3.0
10 stars 13 forks source link

Release process should not rename the css and js files #110

Closed daonb closed 8 years ago

daonb commented 8 years ago

Today, with every release we create new file name s for css and js files. This causes returning user to receive a black page: their index.html includes references to the old names that no longer exist. To solve this issue we need to add the temporary name as a query parameter, i.e. Instead of /scripts/741fc565.vendor.js we should ling to /scripts/vendor.js?v=741fc565

daonb commented 8 years ago

@alonisser makes sense?

alonisser commented 8 years ago

No.. why would a return user get an empty page? unless you are doing some wrong caching somewhere for html pages.. using revved filenames is a best practice and I used it in lots of places. never encountered this problem.

What might be the Real problem: Html pages caching (a big no no) - this isn't client side (since browsers don't cache html) but can be in web server (nginx/apache) or in a cdn/protection layer like cloudflare/incapsula//akamai do you use any of them?

daonb commented 8 years ago

On the server we have an nginx with no caching and we don't use any CDN for now. I'll look at it closely in our next release, but for now, I'm closing this.

alonisser commented 8 years ago

Don't close yet. please send me nginx.conf (the main and the default.conf or something similar)

alonisser commented 8 years ago

Please notify me before and after the deploy so I can witness the effect my self

On Mon, Jun 20, 2016 at 1:15 PM benny daon notifications@github.com wrote:

On the server we have an nginx with no caching and we don't use any CDN for now. I'll look at it closely in our next release, but for now, I'm closing this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Beit-Hatfutsot/dbs-front/issues/110#issuecomment-227103442, or mute the thread https://github.com/notifications/unsubscribe/ABXlcCwJ51T88Elc-eMqxqymDbg052Ruks5qNmg-gaJpZM4I5JoI .

alonisser commented 8 years ago

Also main.css looks double there.. Not sure where this come s from

On Mon, Jun 20, 2016 at 6:27 PM alonn alonisser@gmail.com wrote:

Please notify me before and after the deploy so I can witness the effect my self

On Mon, Jun 20, 2016 at 1:15 PM benny daon notifications@github.com wrote:

On the server we have an nginx with no caching and we don't use any CDN for now. I'll look at it closely in our next release, but for now, I'm closing this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Beit-Hatfutsot/dbs-front/issues/110#issuecomment-227103442, or mute the thread https://github.com/notifications/unsubscribe/ABXlcCwJ51T88Elc-eMqxqymDbg052Ruks5qNmg-gaJpZM4I5JoI .