Beit-Hatfutsot / dbs-front

Frontend code for http://dbs.bh.org.il
GNU Affero General Public License v3.0
10 stars 13 forks source link

Duplicate and broken results in ftree search. #264

Closed daonb closed 7 years ago

daonb commented 7 years ago

@TheGrandVizier commented on Mon Jun 06 2016

From @TheGrandVizier on June 2, 2016 7:30

Some results appear twice. The duplicate result,when clicked, produces a blank tree page.

Reproduce:

  1. Search for the name "Magen".
  2. Refine the search to tree 1181
  3. Click each of the duplicate personas.

Result: http://prntscr.com/b52kib

Copied from original issue: Beit-Hatfutsot/dbs-front#44


@TheGrandVizier commented on Mon Sep 05 2016

Not fixed. The second ofer still produces an empty tree view and a console-full of errors.

http://img.prntscr.com/img?url=http://i.imgur.com/Wjodt8W.png


@daonb commented on Sun Sep 25 2016

Seems like the problem is related to persons that have no tree info. It's probably related to #20


@daonb commented on Mon Nov 07 2016

seems like it's a good time to re-test.


@TheGrandVizier commented on Tue Nov 08 2016

Not fixed. There is still a blank for the second Dror Magen. Once the working one is viewed, the first one also is viable via Recently Viewed.


@daonb commented on Wed Nov 09 2016

It happens with: http://test.dbs.bh.org.il/person/1181/0/I0241 and while it is a bug, it's been on the live server for quite some time : http://dbs.bh.org.il/person/1181/I0241


@nuritgazit commented on Wed Nov 09 2016

@daonb meaning?

daonb commented 7 years ago

The bug was when trying to display persons with siblings and no parents. For now, we're just handling it nicer (no errors on the browser's console) and not displaying the siblings.