Beit-Hatfutsot / dbs-front

Frontend code for http://dbs.bh.org.il
GNU Affero General Public License v3.0
10 stars 13 forks source link

General search freezes browser, breaks results page. #314

Closed TheGrandVizier closed 7 years ago

TheGrandVizier commented 7 years ago

After using general search, the following takes place:

  1. The browser freezes.
  2. Many objects are unclickable.
  3. Using the result tabs causes freezes to the browser.
  4. The main site tabs are broken: http://prntscr.com/eec7e5
  5. Item pages load with footer in the middle of the page: http://prntscr.com/eec7mw

Reproduce:

  1. enter test.dbs.bh.org.il
  2. use general search, search for anything.
Inna-r commented 7 years ago

@OriHoch , there is "WARNING: Tried to load angular more than once." in the console

OriHoch commented 7 years ago

@Inna-r - the problem is that the svg files are not in the correct place for static files, so the server returns the 404 page when making a request to svg file and this causes the entire app to reload multiple times

for example - http://test.dbs.bh.org.il/templates/svgs/family_names.svg

the files should be in images directory, or alternatively, modify the gulpfile to support the proper distribution of those files

OriHoch commented 7 years ago

you can test the server distribution locally by running: $ gulp dist

this creates dist directory which contains the files that are on the server, you can then serve them locally, e.g. using python: $ cd dist dist$ python -m SimpleHTTPServer

TheGrandVizier commented 7 years ago

Tested, fixed.

OriHoch commented 7 years ago

nice, thanks it's in draft release 0.11.2