family tree search should limit the results total count - Githubissues

Beit-Hatfutsot / dbs-front

Frontend code for http://dbs.bh.org.il

GNU Affero General Public License v3.0

10 stars 13 forks source link

family tree search should limit the results total count #315

Closed OriHoch closed 7 years ago

OriHoch commented 7 years ago

reproduction steps

search in family trees which will produce many results (e.g. last name = "Cohen")
wait for search to complete (will take a long time..)

expected

should return results quickly
total count should show something like:
More then 1000 results found for your query

actual

takes a long time to get the results
total count shows:
45057 Results found for your query
see:

implementation notes

API supports this functionality after Beit-Hatfutsot/dbs-back#113 is merged
the api call to fsearch should include &max_count_results=1000 (can be a different number as well)
when parsing the results - should check if the total is 1000 - then show the more then 1000 results message instead of the specific total

OriHoch commented 7 years ago

tested on production (http://dbs.bh.org.il/he/person?last_name=cohen), looks good