added proper support for svg in gulpfile + fix bug when opening sub-header - Githubissues

Beit-Hatfutsot / dbs-front

Frontend code for http://dbs.bh.org.il

GNU Affero General Public License v3.0

10 stars 13 forks source link

added proper support for svg in gulpfile + fix bug when opening sub-header #317

Closed OriHoch closed 7 years ago

OriHoch commented 7 years ago

fixed the bug in #314 - by adding proper support for svg files in gulpfile
fixed a bug in sub-header:
- reproduction steps: scroll the page down, then click on search or recently viewed in header
- expected: show the search / recently sub-header
- actual: doesn't show the sub-header (if you scroll back up you will see it)
- fixed by scrolling back to top of the page when opening the sub-header
- it's a bit hackish but it works.. I don't think it's worth to invest in a proper solution

OriHoch commented 7 years ago

the annoying scroll down bug was finally fixed and tested on production