Beit-Hatfutsot / dbs-front

Frontend code for http://dbs.bh.org.il
GNU Affero General Public License v3.0
10 stars 13 forks source link

Wrong image title on home page. #322

Closed TheGrandVizier closed 7 years ago

TheGrandVizier commented 7 years ago

On the homepage, we display a background image. That image has a titled link leading to it's item page. The link reads: Girls soldiers standing on a truck. It should be changed to "Female soldiers standing on a truck".

<a ui-sref="item-view ({collection: 'image', local_slug: 'girls-soldiers-standing-on-a-truck-israel-1950s'})" class="ng-scope" href="/image/girls-soldiers-standing-on-a-truck-israel-1950s">Girls soldiers standing on a truck, Israel 1950s.</a>

Should be <a ui-sref="item-view ({collection: 'image', local_slug: 'girls-soldiers-standing-on-a-truck-israel-1950s'})" class="ng-scope" href="/image/girls-soldiers-standing-on-a-truck-israel-1950s">Female soldiers standing on a truck, Israel 1950s.</a>

The title of the image has changed but the slug remains. However, the visible title on the homepage must be changed.

OriHoch commented 7 years ago

@TheGrandVizier I see that the related pull request is merged, what's the status of this issue?

TheGrandVizier commented 7 years ago

Sorry, forgot to move to WIP. All sorted now. Ready for prod.