search

Beit-Hatfutsot / dbs-front

Frontend code for http://dbs.bh.org.il
GNU Affero General Public License v3.0
10 stars 13 forks source link

Family tree display optimization for longer names. #330

Closed TheGrandVizier closed 7 years ago

TheGrandVizier commented 7 years ago

The trees currently do not display long names or multiple names too well.

http://prntscr.com/emkhmv

Reproduce:

  1. Go to Naftali's tree: http://test.dbs.bh.org.il/person/12295/0/I6
  2. Look at Naftali's children.

Expected result: All names visible for every person.

Actual result: One out of three names displayed for children, the rest do not fit in the display.

This may require a slight redesign or at least designs input, @Netush @nuritgazit This is a result of adding all names to be displayed. Now we realize there was a reason we did not display all.

OriHoch commented 7 years ago

@TheGrandVizier - I think it can be solved easily by reducing line height (minimizing spaces between lines) and reducing font-size, I'll try and will see how it looks

Netush commented 7 years ago

The text size should not be reduce - but only the first name should appear at that capsule size (full name appear when hover)

OriHoch commented 7 years ago

gotcha, I'll see what I can do

OriHoch commented 7 years ago

fixed and deployed to production http://dbs.bh.org.il/person/12295/0/I6