search

Beit-Hatfutsot / dbs-front

Frontend code for http://dbs.bh.org.il
GNU Affero General Public License v3.0
10 stars 13 forks source link

Item page displays faulty link to family tree where it shouldnt #331

Closed TheGrandVizier closed 7 years ago

TheGrandVizier commented 7 years ago

Arriving at any page from general search results, there is a faulty link to a family tree that should not be there on the top right of the page: http://prntscr.com/emmgfh

Reproduce:

  1. Use general search: Cohen
  2. Click on any result.

Expected result: Item page with no attached / "docked" items.

Actual result: Item page with "docked" family tree link that doesnt leads to person search.

Note: This type of link should only exist for results originating in wizard.

OriHoch commented 7 years ago

@TheGrandVizier - is this a regression? or an existing bug? It doesn't look like something caused by the deployment

TheGrandVizier commented 7 years ago

I believe its regression. This doesn't occur on test.

OriHoch commented 7 years ago

ok, I'll investigate

OriHoch commented 7 years ago

most likely is that it's a local bug which only you see due to some data left in your session storage

you should try to clear it by typing in console sessionStorage.clear(): image

then see if it reproduces..

I don't think it's worth to investigate much further, it's likely it happens to you because you saw a lot of bugs which might have stored some problematic data in your session storage.

regarding your note that it shouldn't even appear - please open in a new issue

TheGrandVizier commented 7 years ago

Yea, my bad, false flag. How noob of me. Apologies.