Beit-Hatfutsot / dbs-front

Frontend code for http://dbs.bh.org.il
GNU Affero General Public License v3.0
10 stars 13 forks source link

should show user friendly error page in case of invalid / forbidden item (or any other unexpected problem in any page) #333

Open OriHoch opened 7 years ago

OriHoch commented 7 years ago

ideally - we should have this issue for any unexpected problem, not only for item page

reproduction steps

expected
actual
OriHoch commented 7 years ago

@Netush - perhaps some design is needed.. @TheGrandVizier - please prioritize

TheGrandVizier commented 7 years ago

@OriHoch this shouldnt happen because the user shouldnt reach that far. This item should not be returned as a search result, and should not be migrated to start with.

OriHoch commented 7 years ago

@TheGrandVizier - you are correct, but there will always be some problem now it's forbidden image, tomorrow it will be another problem.. we should have consistent and user friendly error pages

TheGrandVizier commented 7 years ago

@OriHoch agreed, but, does it matter that it's 403 or 404 to the user? I think the 404 page can be used in this case.

OriHoch commented 7 years ago

sure, if that's a good enough solution for you, that's fine

IMO there should be minimum of 2 error pages, and both should include follow-up to the user -

But, of course, we need to prioritize..

TheGrandVizier commented 7 years ago

prioritized.

Netush commented 7 years ago

I agree that the these messages should be more visible and friendly. Just a reminder, there was a design for the error messages but there was a decision to do something more easy - ready made.

OriHoch commented 7 years ago

@Netush - please add here these designs

nuritgazit commented 7 years ago

Ok, let's end the dicussion: For now let's use the design of the 404 page for such cases (= there is no content in the page). For the other cases where we need to tell something to the user, we can still use the existing error messages that appear on the top of the page. in the future we will change it to the designed error message