Beit-Hatfutsot / dbs-front

Frontend code for http://dbs.bh.org.il
GNU Affero General Public License v3.0
10 stars 13 forks source link

The main general search query field does't work well with persons filters fields #348

Closed Inna-r closed 7 years ago

Inna-r commented 7 years ago

General 'Persons search' considers main query as last or first name ("Paris" also will be searched in person's name), so if one of these fields is filled inside filters form we got no results. Reproduce:

OriHoch commented 7 years ago

I think it's a design issue @Netush @TheGrandVizier

TheGrandVizier commented 7 years ago

The filters should ignore the original search and only be applied on the results of that search.

Scenario 1:

  1. Search for Moscow in general search, get results.
  2. Go to "Person" tab. Filters now visible.
  3. Apply a filter. Name: Levi.
  4. Click "Filter".

Expected Result: Results displayed are narrowed down from previous batch (moscow-containing trees) to only people with Levi in their name that existed in previous results (are from moscow or related to someone named moscow).

Actual Result: No results are found.

TheGrandVizier commented 7 years ago

@Inna-r updated issue

TheGrandVizier commented 7 years ago

@OriHoch Inna says this is a backend bug. Can we please get some clarity on this issue?

OriHoch commented 7 years ago

@Inna-r please open a corresponding backend bug

OriHoch commented 7 years ago

@Inna-r @TheGrandVizier I suggest to open new issue for every bug, it's very hard to track the problem..

@TheGrandVizier - regarding your reproduction steps - I don't see a problem there when you do a general search query for "Moscow", none of the results have a person named "Levi" - hence no results - this is valid

@Inna-r - regarding your description, I didn't fully understand what is you expected results

in any case, I opened a dbs-back issue with a possible problem:

Beit-Hatfutsot/dbs-back#181

feel free to close this issue if the backend issue covers all your problems..

TheGrandVizier commented 7 years ago

Thanks, indeed it does. Closing this.